Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make datStats endpoint dag_ids parameter optional #42955

Merged
merged 3 commits into from
Oct 13, 2024
Merged

Make datStats endpoint dag_ids parameter optional #42955

merged 3 commits into from
Oct 13, 2024

Conversation

michaeljs-c
Copy link
Contributor

closes: #41495

Makes the dag_ids parameter optional in the dagStats endpoint. If not provided, the endpoint returns stats for all DAGs in a paginated result set.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Oct 11, 2024
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Oct 11, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@michaeljs-c michaeljs-c force-pushed the dag-stats-parameter-optional-with-pagination branch from 41bea17 to fd1e16d Compare October 11, 2024 18:48
@michaeljs-c michaeljs-c changed the title Make datStats endpoint dag_ids parameter optional with pagination Make datStats endpoint dag_ids parameter optional Oct 11, 2024
@michaeljs-c michaeljs-c force-pushed the dag-stats-parameter-optional-with-pagination branch from d23b665 to 52fac56 Compare October 12, 2024 20:58
@michaeljs-c michaeljs-c marked this pull request as ready for review October 12, 2024 21:01
@jscheffl jscheffl added the legacy api Whether legacy API changes should be allowed in PR label Oct 13, 2024
@jscheffl jscheffl force-pushed the dag-stats-parameter-optional-with-pagination branch from 52fac56 to 3768fb6 Compare October 13, 2024 10:13
@jscheffl jscheffl added the legacy ui Whether legacy UI change should be allowed in PR label Oct 13, 2024
@jscheffl jscheffl force-pushed the dag-stats-parameter-optional-with-pagination branch from 3768fb6 to 0d36cc8 Compare October 13, 2024 10:39
@jscheffl jscheffl added this to the Airflow 3.0.0 milestone Oct 13, 2024
jscheffl
jscheffl approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the changes will need to be ported to new FAST API as we are changing from connexion, but API in this change stays compatible.

@jscheffl jscheffl merged commit ad54501 into apache:main Oct 13, 2024
56 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Oct 13, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

pavansharma36 pushed a commit to pavansharma36/airflow that referenced this pull request Oct 14, 2024
@michaeljs-c @pavansharma36
Make datStats endpoint dag_ids parameter optional (apache#42955)
201a4d6 
* Make datStats dag_id parameter optional with pagination

* move pagination out of sql query

* tidy

---------

Co-authored-by: Michael Smith-Chandler <mjsmithandler@gmail.com>
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
@michaeljs-c
Make datStats endpoint dag_ids parameter optional (apache#42955)
b19a945 
* Make datStats dag_id parameter optional with pagination

* move pagination out of sql query

* tidy

---------

Co-authored-by: Michael Smith-Chandler <mjsmithandler@gmail.com>
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
@michaeljs-c @harjeevanmaan
Make datStats endpoint dag_ids parameter optional (apache#42955)
f120cce 
* Make datStats dag_id parameter optional with pagination

* move pagination out of sql query

* tidy

---------

Co-authored-by: Michael Smith-Chandler <mjsmithandler@gmail.com>
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
@michaeljs-c @PaulKobow7536
Make datStats endpoint dag_ids parameter optional (apache#42955)
dfd05c4 
* Make datStats dag_id parameter optional with pagination

* move pagination out of sql query

* tidy

---------

Co-authored-by: Michael Smith-Chandler <mjsmithandler@gmail.com>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@michaeljs-c @ellisms
Make datStats endpoint dag_ids parameter optional (apache#42955)
0f9c870 
* Make datStats dag_id parameter optional with pagination

* move pagination out of sql query

* tidy

---------

Co-authored-by: Michael Smith-Chandler <mjsmithandler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jscheffl jscheffl jscheffl approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues legacy api Whether legacy API changes should be allowed in PR legacy ui Whether legacy UI change should be allowed in PR
Projects
None yet
Milestone
Airflow 3.0.0
Development

Successfully merging this pull request may close these issues.

Make dag_ids parameter optional for dagStats REST API
2 participants
@michaeljs-c @jscheffl