-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove redundant scheduler_lock column from dag table #43023
remove redundant scheduler_lock column from dag table #43023
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
You have some conflicts. This seems like a breaking change even though the column is not used |
2d85a30
to
06de7f9
Compare
Assigning |
06de7f9
to
99e34ea
Compare
LGTM. When was this first added, by who, for what? (We can at least answer that with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One minor comment inline to remove the duplicate migration script.
airflow/migrations/versions/486ac7936b78_remove_scheduler_lock_column.py
Outdated
Show resolved
Hide resolved
d12f2b1
to
4faf9e9
Compare
airflow/migrations/versions/0041_3_0_0_remove_scheduler_lock_column.py
Outdated
Show resolved
Hide resolved
6f45152
to
87afa3e
Compare
87afa3e
to
51a9ee6
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Congrats on your first PR @prabhusneha 🎉🎉 |
* remove scheduler_lock column from dag table * add migration script * add migration script * add migration script * add migration script * delete duplicate file * remove scheduler_lock column * remove scheduler_lock column * remove scheduler_lock column * remove scheduler_lock column * remove scheduler_lock column * resolve conflicts --------- Co-authored-by: Sneha Prabhu <snehaprabhu@Snehas-MacBook-Pro.local>
closes: #42258
Remove all scheduler_lock references from the codebase.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.