Fix generation of commit history after moving providers #43412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
eladkal,
utkarsharma2,
romsharon98,
amoghrajesh and
omkar-foss
Another teething problem after moving providers in apache#42505. After moving providers, the history of the current folder in "providers" only contains changes after the move - it does not include changes from before the move - and since we always regenerate the full list of commits - they were missing. We cannot use `--follow` - because `git log --follow` only works for single files, not directories, but since the move was very predictable ("airflow/providers/nnn" -> "airflow/providers/src/airflow/providers/nnn") we can add the old path to `git log` command to get both - pre and post move commit history.
potiuk
force-pushed
the
fix-provider-commit-list
branch
from
d052906
to
bf88970
Compare
eladkal
approved these changes
Oct 27, 2024
|
Yep - it nicely works in CI as well: 
Compared to (in main): 
|
|
The doc failure is unrelated - seems that sqlalchemy doc inventory was temporarily unavailable. Merging - since the changes are only in "doc generation" and it already passed. |
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
Another teething problem after moving providers in apache#42505. After moving providers, the history of the current folder in "providers" only contains changes after the move - it does not include changes from before the move - and since we always regenerate the full list of commits - they were missing. We cannot use `--follow` - because `git log --follow` only works for single files, not directories, but since the move was very predictable ("airflow/providers/nnn" -> "airflow/providers/src/airflow/providers/nnn") we can add the old path to `git log` command to get both - pre and post move commit history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another teething problem after moving providers in #42505. After moving providers, the history of the current folder in "providers" only contains changes after the move - it does not include changes from before the move - and since we always regenerate the full list of commits - they were missing.
We cannot use
--follow- becausegit log --followonly works for single files, not directories, but since the move was very predictable ("airflow/providers/nnn" ->"airflow/providers/src/airflow/providers/nnn") we can add the old path to
git logcommand to get both - pre and post move commit history.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.