Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate public endpoint Get Task to FastAPI #43718

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

omkar-foss
Copy link
Collaborator

closes: #42874
related: #42370

This migrates the Get Task API from api_connexion to api_fastapi.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 5, 2024
@omkar-foss omkar-foss added the legacy api Whether legacy API changes should be allowed in PR label Nov 5, 2024
@omkar-foss omkar-foss self-assigned this Nov 5, 2024
@omkar-foss
Copy link
Collaborator Author

omkar-foss commented Nov 8, 2024

@pierrejeambrun PR rebased and synced with main and all comments resolved, please check it out. Thank you!

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good. Need rebasing and conflicts resolution. Thanks

airflow/api_fastapi/common/types.py Outdated Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_tasks.py Outdated Show resolved Hide resolved
@omkar-foss
Copy link
Collaborator Author

Overall looking good. Need rebasing and conflicts resolution. Thanks

Done! Rebased and conflicts resolved ✅

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebasing again. Ready to merge

@omkar-foss
Copy link
Collaborator Author

omkar-foss commented Nov 13, 2024

Needs rebasing again. Ready to merge

@pierrejeambrun rebasing done, thank you ✅

@pierrejeambrun pierrejeambrun merged commit 6519657 into apache:main Nov 13, 2024
56 checks passed
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Migrate public endpoint Get Task to FastAPI, with main resynced

* Re-run static checks

* Remove extra router line
@omkar-foss omkar-foss deleted the aip-84/tasks/get-task branch November 14, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIP-84 Migrate the public endpoint Get Task to FastAPI
4 participants