Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP 84: Migrate GET ASSET EVENTS legacy API to fast API #43881

Merged
merged 44 commits into from
Nov 14, 2024

Conversation

vatsrahul1001
Copy link
Collaborator

@vatsrahul1001 vatsrahul1001 commented Nov 11, 2024

Migrating the connexion API for GET ASSETS EVENTS to fastAPI.

Depends on #43783
related: #43845

Swagger Specs

image image

Response JSON

{
  "asset_events": [
    {
      "id": 1,
      "asset_id": 1,
      "asset_uri": "s3://bucket/key/1",
      "extra": {
        "foo": "bar"
      },
      "source_task_id": "source_task_id",
      "source_dag_id": "source_dag_id",
      "source_run_id": "source_run_id_1",
      "source_map_index": -1,
      "created_dagruns": [
        {
          "run_id": "source_run_id_1",
          "dag_id": "source_dag_id",
          "logical_date": "2020-06-11T18:00:00Z",
          "start_date": "2020-06-11T18:00:00Z",
          "end_date": "2020-06-11T18:00:00Z",
          "state": "success",
          "data_interval_start": "2020-06-11T18:00:00Z",
          "data_interval_end": "2020-06-11T18:00:00Z"
        }
      ],
      "timestamp": "2020-06-11T18:00:00Z"
    },
    {
      "id": 2,
      "asset_id": 2,
      "uri": "s3://bucket/key/2",
      "extra": {
        "foo": "bar"
      },
      "source_task_id": "source_task_id",
      "source_dag_id": "source_dag_id",
      "source_run_id": "source_run_id_2",
      "source_map_index": -1,
      "created_dagruns": [
        {
          "run_id": "source_run_id_2",
          "dag_id": "source_dag_id",
          "logical_date": "2020-06-11T18:00:00Z",
          "start_date": "2020-06-11T18:00:00Z",
          "end_date": "2020-06-11T18:00:00Z",
          "state": "success",
          "data_interval_start": "2020-06-11T18:00:00Z",
          "data_interval_end": "2020-06-11T18:00:00Z"
        }
      ],
      "timestamp": "2020-06-11T18:00:00Z"
    }
  ],
  "total_entries": 2
}

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 11, 2024
@vatsrahul1001 vatsrahul1001 changed the title Aip84 get asset events AIP 84: Migrate GETASSET EVENTS legacy API to fast API Nov 11, 2024
@vatsrahul1001 vatsrahul1001 changed the title AIP 84: Migrate GETASSET EVENTS legacy API to fast API AIP 84: Migrate GET ASSET EVENTS legacy API to fast API Nov 11, 2024
@vatsrahul1001 vatsrahul1001 marked this pull request as draft November 11, 2024 12:37
@vatsrahul1001 vatsrahul1001 added the legacy api Whether legacy API changes should be allowed in PR label Nov 11, 2024
@amoghrajesh amoghrajesh self-requested a review November 13, 2024 14:06
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just a few suggestions

Do you mind rebasing, base branch has been merged, this will make the review easier.

I'll do a final review then.

You just did during my inital review, thanks :) checking again.

airflow/api_fastapi/core_api/routes/public/assets.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/datamodels/assets.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/datamodels/assets.py Outdated Show resolved Hide resolved
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, overall looking good.

airflow/api_fastapi/core_api/datamodels/assets.py Outdated Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_assets.py Outdated Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_assets.py Outdated Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_assets.py Outdated Show resolved Hide resolved
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

One last small modification needed following #43932 and we can merge

airflow/api_fastapi/core_api/routes/public/assets.py Outdated Show resolved Hide resolved
@pierrejeambrun pierrejeambrun merged commit 9a364ac into apache:main Nov 14, 2024
56 checks passed
@pierrejeambrun pierrejeambrun deleted the AIP84-get-asset-events branch November 14, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants