Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Redirect old location module imports to standard provider (#4… #43946

Merged
merged 1 commit into from
Nov 13, 2024

Commits on Nov 13, 2024

  1. Revert "Redirect old location module imports to standard provider (ap…

    …ache#43610)"
    
    There is a very interesting breaking change introduced in Python 3.11
    that will likely mean that we should not use MetaPathFinder for old
    standard provider classes redirection.
    
    There was a change introduced in Python 3.11 that caused that
    module might not be found in some cases (for example when
    unit test patches the path) when the module is loaded as
    a different module (i.e. a.b differs from sys.modules['a.b'])
    
    This is tracked in CPython via:
    python/cpython#117860
    
    This causes standard operator's tests fail in Python 3.11 and
    3.12 when the providers/tests/standard/test_module_redirect_finder.py
    is executed before - i.e. the standard modules are loaded as
    old modules.
    
    This reverts commit 5de2e73.
    potiuk committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ffba796 View commit details
    Browse the repository at this point in the history