Fix parsing of development dependencies for airflow version #43995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script to install development dependencies asumed development dependencies are always `>=` this might not be true in case we limit the depdencies to be < or provide other requirements for them. This PR fixes it by using "packaging.requirements.Requirement" to parse the specifier, which should handle all cases nicely.
dstandish
approved these changes
Nov 13, 2024
kaxil
approved these changes
Nov 13, 2024
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Nov 14, 2024
…3995) The script to install development dependencies asumed development dependencies are always `>=` this might not be true in case we limit the depdencies to be < or provide other requirements for them. This PR fixes it by using "packaging.requirements.Requirement" to parse the specifier, which should handle all cases nicely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script to install development dependencies asumed development dependencies are always
>=this might not be true in case we limit the depdencies to be < or provide other requirements for them.This PR fixes it by using "packaging.requirements.Requirement" to parse the specifier, which should handle all cases nicely.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.