-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snowflake to slack operator #9023
Add snowflake to slack operator #9023
Conversation
Addition of a new `snowflake_to_slack` operator. The operator allows you to run a SQL statement against Snowflake and render the results into a Slack message.
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
@potiuk , could you confirm that TravisCI fail is not related to that PR? |
@ad-m We have temporary problems with Kubernetes tests running on Travis Ci. This change does not apply to Kubernetes, so it is safe. @dimberman is working on improvements for Kubernetes tests. |
Thanks for the review @turbaszek , just updated the PR with the changes you've suggested. |
@feluelle Thanks for the review. I've made your suggested changes and ready for another look when you get a chance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you only want to init the hooks once not multiple times accidently :)
Can the result be sent as attachment file to the message? |
Awesome work, congrats on your first merged pull request! |
@JeffryMAC this can be added as feature request :) |
Addition of a new operator (
snowflake_to_slack
), the operator allows users to execute an SQL query in Snowflake and render the results into Slack. This operator renders the results of the SQL query as a Pandas Dataframe into theslack_message
JINJA template variable.Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.