-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos, older versions, and deprecated operators with AI platform example DAG #9618
Conversation
Fix typos, older versions, and deprecated operators with AI platform example DAG
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
@mik-laj You mentioned that this DAG does not have accompanying tests. How should I go about addressing the Unit tests coverage bullet above? Additionally, should I make this a draft PR while I work on the corresponding documentation? |
@vuppalli We don't need unit tests for DAG. We use them in the documentation and in system tests. System tests are sufficient in this case. Have the files that are needed to run the tests changed? It is better if the contribution is small because then it is much easier to review and merge in the project. In this case, I would prefer you to create a new PR that will only contain documentation. If you need any changes that are included in this PR then you can copy the changes from this PR and add annotations in the PR title
In order for this change to be merged, you must fix static check errors.
+ isort For more information: How do you like an internship at Google? Do you have any concerns about contributing to Open Source? The community of this project is very open to new contributors and interns. We currently have two active interns who contribute to the project. If you would like to get more involved in this project, we'll be happy to help. Apache Airflow is the core of the Cloud Composer service, so contributions to this project will be appreciated by your company. |
fix trailing whitespace
@mik-laj Thanks so much for your response. I am not sure which files are needed to run the tests so I do not know if they have changed. The only file I have contributed to is the example DAG. Also, I have fixed the trailing whitespace issues and will create a new PR for the guide sometime this week. I am really enjoying my internship at Google and this contribution is quite relevant the work I am doing! Since I am working with Cloud Composer and AI Platform, I am grateful to have helped with this contribution as I learned a lot about both products. I would love to get more involved with Open Source and appreciate the help! |
@vuppalli Are you available on our official Airflow Slack channel? https://apache-airflow-slack.herokuapp.com/ If you plan to contribute more to Airflow, we can coordinate my team and your work. My team looks after all Google integrations, so we'll have a lot of contacts. |
@mik-laj Yes, thank you! |
I sent DM to you. ;-) |
Fix grammer in prerequisite_tasks.rst for GCP operator documentation
The AI platform example DAG had typos, was using older versions, and had deprecated operators. This PR is an attempt to fix these problems and corresponds to this Github issue. The relevant documentation will be updated soon (most likely next week), which corresponds to this Github issue. I will address any comments next Monday (07/06) since we have US holidays for the rest of the week. I look forward to getting feedback!
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.