Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dashboard supports selecting: Service Discovery when creating an upstream #1977

Closed
tzssangglass opened this issue Jul 13, 2021 · 8 comments · Fixed by #2081
Closed
Assignees
Labels
enhancement New feature or request frontend service discovery issues related to service discovery
Milestone

Comments

@tzssangglass
Copy link
Member

tzssangglass commented Jul 13, 2021

Feature request

Support the configuration of discovery_type and service_name.

related issue

@juzhiyuan
Copy link
Member

Just updated your first comment, and I will take this.

@liuxiran liuxiran added this to the 2.7.2 milestone Aug 17, 2021
@bzp2010 bzp2010 added backend enhancement New feature or request frontend labels Aug 18, 2021
@liuxiran
Copy link
Contributor

#1557

BE has already support this feature, remove backend tag

@liuxiran liuxiran removed the backend label Aug 19, 2021
@liuxiran
Copy link
Contributor

Refer to the https://apisix.apache.org/docs/apisix/2.7/discovery#supported-discovery-registries

In APISIX2.7 , we support Eureka/Consul/Nacos and service discovery via DNS,

in order to support this feature in dashboard, we have to update our Upstream module, add Target type filed, user can choose Node or Service Discovery

when choose Node, user can complete the follow fields:
image

When choose Service Discovery, user can complete the following fields:
discovery_type, a list of dnsconsul_kv nacos and eureka
service_name , input the your configured service name

It should be noted that, when discovery_type choose nacos, discovery_args can be configured, see: https://apisix.apache.org/docs/apisix/2.7/discovery/nacos#discovery_args for details.

cc @bzp2010 @juzhiyuan @Baoyuantop @tzssangglass @nic-chen @spacewander to help to check whether I missed some thing for this feature, thanks a lot.

@liuxiran liuxiran added the service discovery issues related to service discovery label Aug 19, 2021
@spacewander
Copy link
Member

LGTM

3 similar comments
@juzhiyuan
Copy link
Member

LGTM

@nic-chen
Copy link
Member

LGTM

@Baoyuantop
Copy link
Contributor

LGTM

@bzp2010
Copy link
Contributor

bzp2010 commented Aug 19, 2021

This issue is similar to issue #1989, and I will try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend service discovery issues related to service discovery
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants