-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add service discovery config #2081
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: e3c2735 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/612c4765475f75000710a545 😎 Browse the preview: https://deploy-preview-2081--apisix-dashboard.netlify.app/ |
Codecov Report
@@ Coverage Diff @@
## master #2081 +/- ##
==========================================
+ Coverage 68.80% 71.07% +2.26%
==========================================
Files 181 60 -121
Lines 7005 3779 -3226
Branches 787 0 -787
==========================================
- Hits 4820 2686 -2134
+ Misses 1901 809 -1092
Partials 284 284
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Update
|
Request help @bzp2010 @tzssangglass @spacewander please help me to make sure when we configure service discovery, can we configure these fields? Since I have not fond the related examples, and some of the fields such as timeouts configured in the yaml file |
|
web/cypress/integration/route/create-route-with-service-discovery-upstream.spec.js
Outdated
Show resolved
Hide resolved
web/cypress/integration/route/create-route-with-service-discovery-upstream.spec.js
Outdated
Show resolved
Hide resolved
web/cypress/integration/route/create-route-with-service-discovery-upstream.spec.js
Show resolved
Hide resolved
please pay attention to
when choose |
I ignored the params and I will improve it immediately. |
0c262d0
to
327d977
Compare
327d977
to
0fb902c
Compare
web/cypress/integration/route/create-route-with-service-discovery-upstream.spec.js
Show resolved
Hide resolved
web/cypress/integration/route/create-route-with-service-discovery-upstream.spec.js
Outdated
Show resolved
Hide resolved
web/cypress/integration/route/create-route-with-service-discovery-upstream.spec.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
also cc @Baoyuantop @foolwc @iamayushdas to review, thanks very much |
LGTM |
@LiteSun The problem has been modified. Please review it again. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
This PR introduces UI based service discovery configuration.
Related issues
resolve: #1977 #1989
Checklist: