Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user can skip upstream when select service_id #1302

Merged
merged 14 commits into from
Jan 22, 2021

Conversation

LiteSun
Copy link
Member

@LiteSun LiteSun commented Jan 14, 2021

Please answer these questions before submitting a pull request


New feature or improvement

  • Describe the details and related test reports.
    user can skip upstream when select service_id.

Please add the corresponding test cases if necessary.

  • Todo

@liuxiran
Copy link
Contributor

just to make sure that this pr could also solves #1278 , if so I will move to other issues, thanks ^-^

cc @LiteSun @juzhiyuan

@liuxiran liuxiran marked this pull request as ready for review January 15, 2021 00:22
@liuxiran liuxiran marked this pull request as draft January 15, 2021 01:32
@LiteSun
Copy link
Member Author

LiteSun commented Jan 15, 2021

just to make sure that this pr could also solves #1278 , if so I will move to other issues, thanks ^-^

cc @LiteSun @juzhiyuan

According to the issue(#1278) description, this PR will resolve the issue. 😄

@codecov-io
Copy link

codecov-io commented Jan 15, 2021

Codecov Report

Merging #1302 (909fc2f) into master (749eeb5) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1302      +/-   ##
==========================================
+ Coverage   44.36%   44.47%   +0.11%     
==========================================
  Files          31       32       +1     
  Lines        1961     1965       +4     
==========================================
+ Hits          870      874       +4     
- Misses        979      980       +1     
+ Partials      112      111       -1     
Impacted Files Coverage Δ
api/cmd/manager/main.go 0.00% <0.00%> (ø)
api/internal/core/store/store.go 81.48% <0.00%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 749eeb5...909fc2f. Read the comment docs.

@LiteSun LiteSun changed the title WIP: user can skip upstream when select service_id feat: user can skip upstream when select service_id Jan 21, 2021
@LiteSun LiteSun marked this pull request as ready for review January 21, 2021 12:28
@LiteSun
Copy link
Member Author

LiteSun commented Jan 22, 2021

Ping

@guoqqqi guoqqqi mentioned this pull request Jan 22, 2021
4 tasks
@LiteSun LiteSun merged commit 6c3f35c into apache:master Jan 22, 2021
@LiteSun LiteSun deleted the feat-route branch January 22, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants