Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added tip on the Metrics page #1479

Merged
merged 2 commits into from
Feb 19, 2021
Merged

feat: added tip on the Metrics page #1479

merged 2 commits into from
Feb 19, 2021

Conversation

juzhiyuan
Copy link
Member

@juzhiyuan juzhiyuan commented Feb 18, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

added tip on the Metrics page, to tell users that the Metrics page should be used with Grafana Share URL, and it's stored in local only.

image

NOTE: this is only a tip, no need to add a testcase.

@codecov-io
Copy link

Codecov Report

Merging #1479 (ea591cc) into master (1804c75) will decrease coverage by 13.66%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1479       +/-   ##
===========================================
- Coverage   68.66%   55.00%   -13.67%     
===========================================
  Files          48       48               
  Lines        3038     3038               
===========================================
- Hits         2086     1671      -415     
- Misses        713     1088      +375     
- Partials      239      279       +40     
Impacted Files Coverage Δ
api/internal/core/store/query.go 0.00% <0.00%> (-88.10%) ⬇️
api/internal/core/store/selector.go 0.00% <0.00%> (-75.93%) ⬇️
api/internal/handler/plugin/plugin.go 16.66% <0.00%> (-70.00%) ⬇️
api/internal/utils/runtime/runtime.go 0.00% <0.00%> (-64.29%) ⬇️
api/internal/core/store/validate_mock.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/handler/service/service.go 54.25% <0.00%> (-37.24%) ⬇️
api/internal/handler/ssl/ssl.go 34.69% <0.00%> (-34.19%) ⬇️
api/internal/filter/authentication.go 41.66% <0.00%> (-30.56%) ⬇️
api/internal/core/store/store.go 58.43% <0.00%> (-28.92%) ⬇️
api/internal/filter/ip_filter.go 48.71% <0.00%> (-23.08%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1804c75...ea591cc. Read the comment docs.

Copy link
Contributor

@liuxiran liuxiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

BTW we stored the monitor url locally, how about turn the url as a global config setting, so that when we configed grafana start dashboard, all the user could visit the monitor page without setting the Grafana URL in setting page?

@juzhiyuan
Copy link
Member Author

LGTM.

BTW we stored the monitor url locally, how about turn the url as a global config setting, so that when we configed grafana start dashboard, all the user could visit the monitor page without setting the Grafana URL in setting page?

Just to make sure, does this mean store a local grafana default URL?

@liuxiran
Copy link
Contributor

LGTM.
BTW we stored the monitor url locally, how about turn the url as a global config setting, so that when we configed grafana start dashboard, all the user could visit the monitor page without setting the Grafana URL in setting page?

Just to make sure, does this mean store a local grafana default URL?

emm, I mean store the url in the config file(this may need manager-api's help) instead of localstorage ^_^

@juzhiyuan
Copy link
Member Author

Got it, and if users want a more powerful dashboard, they could use Grafana directly than a single page.

@LiteSun LiteSun merged commit 65f792a into master Feb 19, 2021
@juzhiyuan juzhiyuan deleted the feat-monitor-tip branch February 19, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants