-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added tip on the Metrics page #1479
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1479 +/- ##
===========================================
- Coverage 68.66% 55.00% -13.67%
===========================================
Files 48 48
Lines 3038 3038
===========================================
- Hits 2086 1671 -415
- Misses 713 1088 +375
- Partials 239 279 +40
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
BTW we stored the monitor url locally, how about turn the url as a global config setting, so that when we configed grafana start dashboard, all the user could visit the monitor page without setting the Grafana URL in setting page?
Just to make sure, does this mean store a local grafana default URL? |
emm, I mean store the url in the config file(this may need manager-api's help) instead of localstorage ^_^ |
Got it, and if users want a more powerful dashboard, they could use |
Please answer these questions before submitting a pull request
added tip on the Metrics page, to tell users that the Metrics page should be used with Grafana Share URL, and it's stored in local only.
NOTE: this is only a tip, no need to add a testcase.