feat: rewrite e2e test(upstream_chash_hash_on_test) with ginkgo #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jaycean is this pr ready ? |
Yes, but I'm going to check it again before opening it. |
|
cc @juzhiyuan @liuxiran FE e2e test failed. PTAL. |
|
ping @guoqqqi to take a look |
nic-chen
approved these changes
Mar 1, 2021
LiteSun
pushed a commit
that referenced
this pull request
Mar 1, 2021
starsz
reviewed
Mar 1, 2021
| assert.Nil(t, err) | ||
| req.Header.Add("custom_header", `custom-one`) | ||
| resp, err := http.DefaultClient.Do(req) | ||
| assert.Nil(t, err) |
There was a problem hiding this comment.
You can call the resp.Body.Close here.
| } else { | ||
| res[body]++ | ||
| } | ||
| resp.Body.Close() |
| } else { | ||
| res[body]++ | ||
| } | ||
| resp.Body.Close() |
| } else { | ||
| res[body]++ | ||
| } | ||
| resp.Body.Close() |
| } else { | ||
| res[body]++ | ||
| } | ||
| resp.Body.Close() |
| } else { | ||
| res[body]++ | ||
| } | ||
| resp.Body.Close() |
Jaycean
force-pushed
the
rewrite_e2e_test_upstream_chash_hash_test_with_ginkgo
branch
from
94257db
to
727bd33
Compare
Jaycean
force-pushed
the
rewrite_e2e_test_upstream_chash_hash_test_with_ginkgo
branch
from
e0f8186
to
7f7b35e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1518 +/- ##
===========================================
- Coverage 68.55% 51.63% -16.92%
===========================================
Files 48 39 -9
Lines 3056 2599 -457
===========================================
- Hits 2095 1342 -753
- Misses 722 1083 +361
+ Partials 239 174 -65
Continue to review full report at Codecov.
|
|
cc @starsz PTAL, Thks. |
starsz
approved these changes
Mar 2, 2021
Jaycean
deleted the
rewrite_e2e_test_upstream_chash_hash_test_with_ginkgo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Feat: Rewrite all E2E tests using the Ginkgo #1500
New feature or improvement