Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite e2e test(server_info_test) with ginkgo #1550

Merged

Conversation

Jaycean
Copy link
Member

@Jaycean Jaycean commented Mar 3, 2021

Please answer these questions before submitting a pull request


New feature or improvement

  • Rewrite e2e test(server_info) with ginkgo

@codecov-io
Copy link

codecov-io commented Mar 3, 2021

Codecov Report

Merging #1550 (77679b4) into master (c775e3e) will decrease coverage by 5.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1550      +/-   ##
==========================================
- Coverage   70.13%   64.75%   -5.38%     
==========================================
  Files         129       49      -80     
  Lines        5231     3164    -2067     
  Branches      549        0     -549     
==========================================
- Hits         3669     2049    -1620     
+ Misses       1323      859     -464     
- Partials      239      256      +17     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo 40.04% <ø> (+2.40%) ⬆️
backend-unit-test 51.68% <ø> (+0.08%) ⬆️
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/handler/data_loader/route_import.go 35.08% <0.00%> (-29.84%) ⬇️
api/internal/core/entity/entity.go 75.00% <0.00%> (-25.00%) ⬇️
api/internal/handler/global_rule/global_rule.go 66.12% <0.00%> (-17.75%) ⬇️
api/internal/utils/utils.go 54.11% <0.00%> (-11.77%) ⬇️
api/internal/core/store/storehub.go 63.55% <0.00%> (-10.94%) ⬇️
api/internal/route.go 77.14% <0.00%> (-8.16%) ⬇️
api/internal/handler/route/route.go 71.96% <0.00%> (-6.28%) ⬇️
api/internal/filter/schema.go 49.57% <0.00%> (-5.89%) ⬇️
api/internal/core/storage/etcd.go 47.27% <0.00%> (-3.64%) ⬇️
api/internal/core/store/validate.go 67.03% <0.00%> (-2.24%) ⬇️
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c775e3e...77679b4. Read the comment docs.

@liuxiran
Copy link
Contributor

liuxiran commented Mar 4, 2021

a strange ci failed, just re-run to see the results

@nic-chen
Copy link
Member

nic-chen commented Mar 4, 2021

a strange ci failed, just re-run to see the results

hi, @liuxiran which ci failed ? I think we should fix it

@Jaycean
Copy link
Member Author

Jaycean commented Mar 4, 2021

a strange ci failed, just re-run to see the results

hi, @liuxiran which ci failed ? I think we should fix it

this ci failed, Test building web in multiple node version / build (14.x) (pull_request)

@nic-chen
Copy link
Member

nic-chen commented Mar 4, 2021

this ci failed, Test building web in multiple node version / build (14.x) (pull_request)

ok, thanks.

@Jaycean
Copy link
Member Author

Jaycean commented Mar 4, 2021

this ci failed, Test building web in multiple node version / build (14.x) (pull_request)

ok, thanks.

I saw in the morning that CI failed without any error message

@nic-chen nic-chen merged commit 1997ad7 into apache:master Mar 4, 2021
@nic-chen
Copy link
Member

nic-chen commented Mar 4, 2021

merged, thanks a lot! @Jaycean

@Jaycean Jaycean deleted the rewrite-e2e-test-server-info-test-with-ginkgo branch March 10, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants