feat: rewrite e2e test(route_with_vars_test) with ginkgo #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starsz
reviewed
Mar 5, 2021
| Headers: map[string]string{"k": "header"}, | ||
| Path: `/hello`, | ||
| ExpectStatus: http.StatusOK, | ||
| Sleep: base.SleepTime, |
|
|
||
| ginkgo.It("verify route", func() { | ||
| base.RunTestCase(base.HttpTestCase{ | ||
|
|
nic-chen
approved these changes
Mar 5, 2021
starsz
reviewed
Mar 7, 2021
| Sleep: base.SleepTime, | ||
| }) | ||
| }) | ||
|
|
Codecov Report
@@ Coverage Diff @@
## master #1556 +/- ##
===========================================
- Coverage 70.18% 51.68% -18.51%
===========================================
Files 130 40 -90
Lines 5340 2707 -2633
Branches 549 0 -549
===========================================
- Hits 3748 1399 -2349
+ Misses 1344 1127 -217
+ Partials 248 181 -67
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jaycean
force-pushed
the
rewrite-e2e-test-route-with-vars-test-with-ginkgo
branch
from
b492620
to
8d7e581
Compare
Jaycean
force-pushed
the
rewrite-e2e-test-route-with-vars-test-with-ginkgo
branch
from
8d7e581
to
02f9b85
Compare
|
cc @starsz PTAL Thks. |
LGTM.Thank you very much. : ) |
starsz
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Feat: Rewrite all E2E tests using the Ginkgo #1500
New feature or improvement