Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update sidebar's menuicon #1651

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Conversation

LiteSun
Copy link
Member

@LiteSun LiteSun commented Mar 23, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.
update meunicon
image

Related issues

fix/resolve #1

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-io
Copy link

codecov-io commented Mar 23, 2021

Codecov Report

Merging #1651 (ff218eb) into master (eecadb8) will decrease coverage by 8.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1651      +/-   ##
==========================================
- Coverage   70.33%   61.77%   -8.56%     
==========================================
  Files         134       47      -87     
  Lines        5737     3116    -2621     
  Branches      665        0     -665     
==========================================
- Hits         4035     1925    -2110     
+ Misses       1450      878     -572     
- Partials      252      313      +61     
Flag Coverage Δ
backend-e2e-test 61.77% <ø> (+13.15%) ⬆️
backend-e2e-test-ginkgo 47.84% <ø> (?)
backend-unit-test ?
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/utils/runtime/runtime.go 0.00% <0.00%> (-64.29%) ⬇️
api/internal/core/store/validate_mock.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/core/store/store.go 58.43% <0.00%> (-29.52%) ⬇️
api/internal/handler/service/service.go 62.60% <0.00%> (-26.09%) ⬇️
api/internal/filter/authentication.go 47.22% <0.00%> (-25.00%) ⬇️
api/internal/filter/ip_filter.go 48.71% <0.00%> (-23.08%) ⬇️
api/internal/handler/global_rule/global_rule.go 64.51% <0.00%> (-19.36%) ⬇️
...pi/internal/handler/plugin_config/plugin_config.go 59.57% <0.00%> (-18.09%) ⬇️
api/internal/utils/json_patch.go 44.82% <0.00%> (-13.80%) ⬇️
.../internal/handler/authentication/authentication.go 88.23% <0.00%> (-11.77%) ⬇️
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eecadb8...ff218eb. Read the comment docs.

web/src/helpers.tsx Outdated Show resolved Hide resolved
@nic-chen
Copy link
Member

ping

@juzhiyuan
Copy link
Member

just regenerated the icons, waiting for upload.

@juzhiyuan juzhiyuan changed the title feat: update menuicon feat: update sidebar's menuicon Mar 23, 2021
@Jaycean Jaycean merged commit b5c5056 into apache:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants