Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added limit-req plugin form #1732

Merged
merged 19 commits into from
Apr 14, 2021
Merged

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Apr 9, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Add limit-req plugin form.
image

Related issues

None

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-io
Copy link

codecov-io commented Apr 9, 2021

Codecov Report

Merging #1732 (9461c24) into master (1fa467a) will decrease coverage by 19.11%.
The diff coverage is n/a.

❗ Current head 9461c24 differs from pull request most recent head c8cdac6. Consider uploading reports for the commit c8cdac6 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1732       +/-   ##
===========================================
- Coverage   71.35%   52.23%   -19.12%     
===========================================
  Files          47       38        -9     
  Lines        3128     2661      -467     
===========================================
- Hits         2232     1390      -842     
- Misses        656     1083      +427     
+ Partials      240      188       -52     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test 52.23% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/utils/version.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/filter/request_id.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/entity/entity.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/store/storehub.go 0.00% <0.00%> (-71.03%) ⬇️
api/internal/filter/cors.go 0.00% <0.00%> (-66.67%) ⬇️
api/internal/filter/schema.go 0.00% <0.00%> (-55.47%) ⬇️
api/internal/utils/consts/api_error.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/handler/data_loader/route_import.go 27.41% <0.00%> (-37.50%) ⬇️
api/internal/handler/handler.go 42.59% <0.00%> (-35.19%) ⬇️
api/internal/handler/schema/schema.go 66.66% <0.00%> (-33.34%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa467a...c8cdac6. Read the comment docs.

web/src/components/Plugin/UI/limit-req.tsx Outdated Show resolved Hide resolved
web/src/components/Plugin/UI/limit-req.tsx Outdated Show resolved Hide resolved
web/src/components/Plugin/UI/limit-req.tsx Outdated Show resolved Hide resolved
web/src/components/Plugin/UI/limit-req.tsx Outdated Show resolved Hide resolved
@juzhiyuan
Copy link
Member

Please file a new PR to add Fields Descriptions in tooltip

@netlify
Copy link

netlify bot commented Apr 11, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 69b9e7b

https://deploy-preview-1732--apisix-dashboard.netlify.app

@juzhiyuan
Copy link
Member

@guoqqqi conflicts

@juzhiyuan
Copy link
Member

Please update i18n in a new PR @guoqqqi

@guoqqqi
Copy link
Member Author

guoqqqi commented Apr 14, 2021

OK😆

@juzhiyuan juzhiyuan merged commit f95324f into apache:master Apr 14, 2021
@guoqqqi guoqqqi deleted the add-limit-req branch February 16, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants