Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Service module #1749

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Conversation

juzhiyuan
Copy link
Member

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

  • added Service description;
  • update Service Creator's fields

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@juzhiyuan juzhiyuan requested a review from LiteSun April 11, 2021 10:18
@codecov-io
Copy link

codecov-io commented Apr 11, 2021

Codecov Report

Merging #1749 (8a2625b) into master (8b6080d) will decrease coverage by 0.90%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1749      +/-   ##
==========================================
- Coverage   72.45%   71.54%   -0.91%     
==========================================
  Files         132       47      -85     
  Lines        5721     3128    -2593     
  Branches      649        0     -649     
==========================================
- Hits         4145     2238    -1907     
+ Misses       1334      646     -688     
- Partials      242      244       +2     
Flag Coverage Δ
backend-e2e-test 62.30% <ø> (-0.42%) ⬇️
backend-e2e-test-ginkgo 49.23% <ø> (+0.12%) ⬆️
backend-unit-test 52.29% <ø> (ø)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/store/storehub.go 71.02% <0.00%> (-3.74%) ⬇️
api/internal/core/storage/etcd.go 47.27% <0.00%> (-3.64%) ⬇️
api/internal/core/store/store.go 87.95% <0.00%> (-1.21%) ⬇️
...pages/SSL/components/CertificateUploader/index.tsx
...ages/Route/components/DebugViews/DebugDrawView.tsx
web/src/pages/Consumer/components/Step1.tsx
web/src/pages/Service/service.ts
web/src/helpers.tsx
web/src/pages/Dashboard/service.ts
web/src/pages/Consumer/Create.tsx
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6080d...8a2625b. Read the comment docs.

@netlify
Copy link

netlify bot commented Apr 11, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 9e3d4d4

https://deploy-preview-1749--apisix-dashboard.netlify.app

@juzhiyuan
Copy link
Member Author

ping @LiteSun @bzp2010

Copy link
Contributor

@starsz starsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description LGTM

@juzhiyuan juzhiyuan merged commit f9e1006 into apache:master Apr 14, 2021
@juzhiyuan juzhiyuan deleted the juzhiyuan/service branch April 14, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants