-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: turn off online debug #1903
Conversation
Deploy preview for apisix-dashboard ready! Built with commit e10757a |
Codecov Report
@@ Coverage Diff @@
## master #1903 +/- ##
==========================================
- Coverage 68.85% 67.02% -1.83%
==========================================
Files 122 169 +47
Lines 3111 6314 +3203
Branches 745 745
==========================================
+ Hits 2142 4232 +2090
- Misses 969 1831 +862
- Partials 0 251 +251
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -28,7 +28,7 @@ import ( | |||
|
|||
func TestRoute(t *testing.T) { | |||
gomega.RegisterFailHandler(ginkgo.Fail) | |||
ginkgo.RunSpecs(t, "route online debug suite") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liuxiran how about removing this line instead of commenting out, just like other changes. While I think we could merge it first. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liuxiran how about removing this line instead of commenting out, just like other changes. While I think we could merge it first.
yep, it should be removed or at least add a comment statement why it is commented out, It will be done with other code optimizations later, thanks
This reverts commit 9728a43
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Turn off online debug, this will be reopen after a new degin
Related issues
Checklist: