Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: turn off online debug #1903

Merged
merged 2 commits into from
May 18, 2021
Merged

Conversation

liuxiran
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Turn off online debug, this will be reopen after a new degin

Related issues

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented May 18, 2021

Deploy preview for apisix-dashboard ready!

Built with commit e10757a

https://deploy-preview-1903--apisix-dashboard.netlify.app

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021

Codecov Report

Merging #1903 (e10757a) into master (60593b3) will decrease coverage by 1.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1903      +/-   ##
==========================================
- Coverage   68.85%   67.02%   -1.83%     
==========================================
  Files         122      169      +47     
  Lines        3111     6314    +3203     
  Branches      745      745              
==========================================
+ Hits         2142     4232    +2090     
- Misses        969     1831     +862     
- Partials        0      251     +251     
Flag Coverage Δ
backend-e2e-test 46.70% <ø> (?)
backend-e2e-test-ginkgo 45.30% <ø> (?)
backend-unit-test 52.42% <ø> (?)
frontend-e2e-test 64.03% <ø> (-4.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/route.go 84.84% <ø> (ø)
web/src/pages/Route/List.tsx 84.52% <ø> (-1.36%) ⬇️
.../Route/components/DebugViews/DebugFormDataView.tsx 3.44% <0.00%> (-93.11%) ⬇️
...es/Route/components/DebugViews/DebugParamsView.tsx 9.52% <0.00%> (-90.48%) ⬇️
...Route/components/DebugViews/AuthenticationView.tsx 5.26% <0.00%> (-73.69%) ⬇️
...ages/Route/components/DebugViews/DebugDrawView.tsx 26.85% <0.00%> (-50.29%) ⬇️
web/src/pages/Route/service.ts 85.29% <0.00%> (-2.95%) ⬇️
api/internal/handler/route/route.go 79.59% <0.00%> (ø)
api/internal/handler/handler.go 77.77% <0.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60593b3...e10757a. Read the comment docs.

@liuxiran liuxiran changed the title fix: turn online debug fix: turn off online debug May 18, 2021
@liuxiran liuxiran requested review from juzhiyuan, Jaycean, starsz, membphis, moonming, nic-chen, LiteSun and imjoey and removed request for Jaycean May 18, 2021 06:12
@@ -28,7 +28,7 @@ import (

func TestRoute(t *testing.T) {
gomega.RegisterFailHandler(ginkgo.Fail)
ginkgo.RunSpecs(t, "route online debug suite")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liuxiran how about removing this line instead of commenting out, just like other changes. While I think we could merge it first. 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liuxiran how about removing this line instead of commenting out, just like other changes. While I think we could merge it first.

yep, it should be removed or at least add a comment statement why it is commented out, It will be done with other code optimizations later, thanks

@imjoey imjoey merged commit 9728a43 into apache:master May 18, 2021
Emma2812 added a commit to Emma2812/apisix-dashboard that referenced this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants