-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make service chash key Input inputable and selectable #1982
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: 46fe51c 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/61020760be63c30007cd88fa 😎 Browse the preview: https://deploy-preview-1982--apisix-dashboard.netlify.app |
@foolwc thanks for your nice work~! The current modification is LGTM, it can support customize the hash key. And If you can add some test cases, it will help us merge your PR more quickly. Just refer to apisix-dashboard/web/cypress/integration/upstream/create_and_delete_upstream.spec.js Line 94 in 0b5196f
hash_on cookie, you can type key a customize one and submit successfully.
And refer to apisix-dashboard/web/cypress/integration/upstream/create_and_delete_upstream.spec.js Line 134 in 0b5196f
Thanks again, and looking forward to your test cases. If you have any question, please leave message here, we'll help you |
Codecov Report
@@ Coverage Diff @@
## master #1982 +/- ##
==========================================
+ Coverage 64.01% 64.05% +0.04%
==========================================
Files 122 122
Lines 3154 3158 +4
Branches 753 754 +1
==========================================
+ Hits 2019 2023 +4
Misses 1135 1135
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Fixes #<1952>
Thanks for your detailed explanation of writing e2e test. Please help me review my code again. Thanks a lot. |
web/cypress/integration/service/create-service-with-chash-upstream.spec.js
Outdated
Show resolved
Hide resolved
Thanks for your test cases, it is ok for the whole idea and process👏, and suggestions for improvement I have attached to the review. |
…eam` Fixes #<1952>
Nice work @foolwc , let's wait for CI Thanks~ |
web/cypress/integration/route/create-route-with-chash-upstream.spec.js
Outdated
Show resolved
Hide resolved
web/cypress/integration/route/create-route-with-chash-upstream.spec.js
Outdated
Show resolved
Hide resolved
web/cypress/integration/route/create-route-with-chash-upstream.spec.js
Outdated
Show resolved
Hide resolved
web/cypress/integration/service/create-service-with-chash-upstream.spec.js
Outdated
Show resolved
Hide resolved
web/cypress/integration/service/create-service-with-chash-upstream.spec.js
Outdated
Show resolved
Hide resolved
web/cypress/integration/upstream/create_and_edit_upstream_with_custom_chash_key.spec.js
Outdated
Show resolved
Hide resolved
Co-authored-by: litesun <sunyi@apache.org>
merged, thanks for your contribution @foolwc |
Fixes #1952
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/resolve #1952
Checklist: