Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only auth type plugin need to configure #1983

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

LiteSun
Copy link
Member

@LiteSun LiteSun commented Jul 14, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
only auth type plugin need to configure

Related issues

resolve #1975

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Jul 14, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: dec528c

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/60eea3c1785ba5000895d50d

😎 Browse the preview: https://deploy-preview-1983--apisix-dashboard.netlify.app/

@codecov-commenter
Copy link

Codecov Report

Merging #1983 (a291fc3) into master (1e55aa3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a291fc3 differs from pull request most recent head dec528c. Consider uploading reports for the commit dec528c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1983   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files         122      122           
  Lines        3154     3154           
  Branches      753      753           
=======================================
  Hits         2019     2019           
  Misses       1135     1135           
Flag Coverage Δ
frontend-e2e-test 64.01% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/service.ts 96.15% <ø> (ø)
web/src/components/Plugin/PluginDetail.tsx 65.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e55aa3...dec528c. Read the comment docs.

@LiteSun LiteSun changed the title fix: only auth type plugin need to configure in consumer fix: only auth type plugin need to configure Jul 16, 2021
@LiteSun LiteSun requested a review from Yiyiyimu July 16, 2021 06:56
@juzhiyuan juzhiyuan requested a review from bzp2010 July 16, 2021 15:12
@LiteSun LiteSun requested a review from Jaycean July 19, 2021 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: error using the openid-connect plugin
6 participants