-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules #2001
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: d6e64f8 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/610fdaa37f45c00008fe6b1a 😎 Browse the preview: https://deploy-preview-2001--apisix-dashboard.netlify.app/ |
Codecov Report
@@ Coverage Diff @@
## master #2001 +/- ##
==========================================
+ Coverage 65.69% 65.79% +0.09%
==========================================
Files 121 121
Lines 3204 3207 +3
Branches 778 778
==========================================
+ Hits 2105 2110 +5
+ Misses 1099 1097 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test cases are needed to ensure the feature worked properly |
When you have time, could you please help her with the steps of the test? @liuxiran |
Ok, after check the current test case about referer-restriction form, @wmdmomo can try to add test cases to https://github.com/apache/apisix-dashboard/blob/master/web/cypress/integration/route/create-route-with-referer-restriction-form.spec.js,
thanks a lot |
Hi @wmdmomo if you have any problem please let us know, thanks a lot |
@liuxiran Sorry to reply now. The referer-restriction test case has been completed. |
@wmdmomo The code looks good to me. But please pay attention to the errors in CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wmdmomo Thank you very much for your contribution. XD |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
The PR will change the plugin under plugin/UI (referer-restriction), allowing referer-restriction to dynamically adapt to the back-end json rules.
Related issues
fix/resolve #1588
Checklist: