Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Plugin): add nodelay for limit-req plugin #2021

Merged
merged 4 commits into from
Aug 7, 2021

Conversation

Baoyuantop
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

According to the latest schema.json, add nodelay options to limit-req plugin.

Related issues

fix #2015

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Jul 30, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 434ed69

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/610cc3ede5a91a0008ffb52b

😎 Browse the preview: https://deploy-preview-2021--apisix-dashboard.netlify.app/

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021

Codecov Report

Merging #2021 (434ed69) into master (af85591) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2021      +/-   ##
==========================================
+ Coverage   63.52%   63.58%   +0.06%     
==========================================
  Files         121      121              
  Lines        3213     3213              
  Branches      779      779              
==========================================
+ Hits         2041     2043       +2     
+ Misses       1172     1170       -2     
Flag Coverage Δ
frontend-e2e-test 63.58% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/UI/limit-req.tsx 100.00% <ø> (ø)
web/src/helpers.tsx 72.13% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af85591...434ed69. Read the comment docs.

@juzhiyuan juzhiyuan requested a review from liuxiran August 1, 2021 09:57
@liuxiran
Copy link
Contributor

liuxiran commented Aug 2, 2021

looking forward to your test case, thanks a lot

@Baoyuantop
Copy link
Contributor Author

@liuxiran @guoqqqi

@guoqqqi
Copy link
Member

guoqqqi commented Aug 4, 2021

LGTM

@juzhiyuan juzhiyuan requested a review from LiteSun August 6, 2021 13:26
@juzhiyuan juzhiyuan merged commit f295b7b into apache:master Aug 7, 2021
@Baoyuantop Baoyuantop deleted the fix-plugin-limitReq branch August 7, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync with the latest schema from APISIX 2.7
6 participants