-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support uri/host/remote_addr #2046
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: 1815a17 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/61121dd48250b6000737ddbf 😎 Browse the preview: https://deploy-preview-2046--apisix-dashboard.netlify.app |
Hi @Baoyuantop please fix ci problem when you have time, thanks |
Codecov Report
@@ Coverage Diff @@
## master #2046 +/- ##
==========================================
+ Coverage 65.94% 66.18% +0.24%
==========================================
Files 121 121
Lines 3212 3226 +14
Branches 779 787 +8
==========================================
+ Hits 2118 2135 +17
+ Misses 1094 1091 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@liuxiran Could you please give some test cases so we could test them in this PR? |
test cases should cover @Baoyuantop
cc @juzhiyuan |
And if the origin uri is |
Can |
I think it's ok :) |
cc @iamayushdas @guoqqqi to have a review when you have time |
web/cypress/integration/route/create-route-both-use-uri-uris.spec.js
Outdated
Show resolved
Hide resolved
web/cypress/integration/route/create-route-both-use-uri-uris.spec.js
Outdated
Show resolved
Hide resolved
@Baoyuantop please fix the conflict files first |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
When creating a route, if
Host, Path, and Remote Addrs
have a single value, senduri/host/remote_addr
to the API, and senduris/hosts/remote_addrs
if there are multiple values.Related issues
resolve #2013
Checklist: