-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add el7 in package name #2074
Conversation
Signed-off-by: imjoey <majunjie@apache.org>
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: b904edb 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/611a57e68bbb04000768b164 😎 Browse the preview: https://deploy-preview-2074--apisix-dashboard.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #2074 +/- ##
=======================================
Coverage 71.07% 71.07%
=======================================
Files 60 60
Lines 3779 3779
=======================================
Hits 2686 2686
Misses 809 809
Partials 284 284
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
It's kind of urgent. Ping @juzhiyuan @starsz @Jaycean @liuxiran @nic-chen. PTAL, thanks. |
Signed-off-by: imjoey <majunjie@apache.org>
Signed-off-by: imjoey <majunjie@apache.org>
Signed-off-by: imjoey majunjie@apache.org
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
The package name of apisix-dashboard in CentOS7 has been added with the OS distribution name
el7
, see api7/apisix-build-tools#67 for details. So this PR is going to change the relevant rpm name toapisix-dashboard-${version}-0.el7.x86_64.rpm
from the originalapisix-dashboard-${version}-0.x86_64.rpm
. This PR will also fix the CI failures due to the stale package name.Related issues
Checklist: