-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validate rules in Apisix Dashboard is same as Apisix api #2085
Conversation
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: 791647a 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/6127028e0cfc9f00077ad242 😎 Browse the preview: https://deploy-preview-2085--apisix-dashboard.netlify.app |
marked an unstable test case here: https://github.com/apache/apisix-dashboard/pull/2085/checks?check_run_id=3410472747 |
Hi @iamayushdas , would you please add test case for your changes? just add assertion to check a route name with 101 characters can be added to this test case, apisix-dashboard/web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js Line 86 in fb78963
|
Sure sure |
Codecov Report
@@ Coverage Diff @@
## master #2085 +/- ##
==========================================
- Coverage 68.87% 65.05% -3.82%
==========================================
Files 181 121 -60
Lines 7010 3231 -3779
Branches 787 787
==========================================
- Hits 4828 2102 -2726
+ Misses 1898 1129 -769
+ Partials 284 0 -284
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: foolwc <2934625339@qq.com>
@liuxiran its done |
web/cypress/integration/route/create-edit-duplicate-delete-route.spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/resolve #2057
Checklist: