Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cors method option #2103

Merged
merged 3 commits into from
Sep 1, 2021
Merged

chore: add cors method option #2103

merged 3 commits into from
Sep 1, 2021

Conversation

okaybase
Copy link
Member

@okaybase okaybase commented Aug 30, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Other options can not use * when set allow_credential = true, so add ** option for allow_methods.

Related issues

fix/resolve:

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@netlify
Copy link

netlify bot commented Aug 30, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: 00626fe

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/612cfe1c032eb00008d6226c

😎 Browse the preview: https://deploy-preview-2103--apisix-dashboard.netlify.app/

@liuxiran
Copy link
Contributor

Hi @okaybase , this pr depends on updating the schema.json to the latest right?

@okaybase
Copy link
Member Author

okaybase commented Aug 30, 2021

Hi @okaybase , this pr depends on updating the schema.json to the latest right?

Hi @liuxiran , don't need to sync the latest schema.json, this pr just fix/add some tips and add an method option.

@liuxiran
Copy link
Contributor

Hi @okaybase , this pr depends on updating the schema.json to the latest right?

Hi @liuxiran , don't need to sync the latest schema.json, this pr just fix/add some tips and add an method option.

ok, thanks for your Instructions

juzhiyuan and others added 2 commits August 30, 2021 23:15
@liuxiran liuxiran requested a review from starsz August 31, 2021 23:10
@liuxiran liuxiran merged commit a118a7f into apache:master Sep 1, 2021
@okaybase okaybase deleted the cors branch September 1, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants