-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add cors method option #2103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: 00626fe 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/612cfe1c032eb00008d6226c 😎 Browse the preview: https://deploy-preview-2103--apisix-dashboard.netlify.app/ |
Hi @okaybase , this pr depends on updating the schema.json to the latest right? |
liuxiran
approved these changes
Aug 30, 2021
starsz
reviewed
Aug 30, 2021
starsz
reviewed
Aug 30, 2021
nic-chen
approved these changes
Aug 30, 2021
Co-authored-by: Peter Zhu <starszcan@gmail.com>
starsz
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Other options can not use
*
when setallow_credential = true
, so add**
option forallow_methods
.Related issues
fix/resolve:
Checklist: