-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: plugin_configs should store with etcd prefix #2226
Conversation
b288cd9
to
ad710f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2226 +/- ##
==========================================
+ Coverage 62.43% 69.89% +7.45%
==========================================
Files 57 184 +127
Lines 3905 7257 +3352
Branches 0 824 +824
==========================================
+ Hits 2438 5072 +2634
- Misses 1185 1891 +706
- Partials 282 294 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
LGTM, just wait the CI passed. |
Hi, in this PR, the backend-e2e-ginkgo just run alarm test, is this normal ? |
cc @bzp2010 |
😂,I checked again and there is no problem, I was looking at it wrong before, this test is running so fast I can't believe it |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Use etcd prefix in plugin_configs template
Related issues
plugin_configs miss match when the etcd prefix is not '/apisix'
Checklist: