Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change "Route List" to "Routes" #2453

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Conversation

gymgym1212
Copy link
Contributor

@gymgym1212 gymgym1212 commented May 14, 2022

Signed-off-by: Yeming Gu yeminggood@gmail.com

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Replace Route List with Routes.

But I'm not sure whether it's enough or not.

Related issues

fix/resolve #2387

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: Yeming Gu <yeminggood@gmail.com>
@Baoyuantop
Copy link
Contributor

Need to fix a failed front-end E2E, feel free to leave a message if you need help.

@gymgym1212

This comment was marked as resolved.

@gymgym1212

This comment was marked as resolved.

@gymgym1212

This comment was marked as abuse.

@gymgym1212

This comment was marked as resolved.

@gymgym1212
Copy link
Contributor Author

Hi @Baoyuantop , I create a test branch in my forked repo and the ci passed all the test. The only difference is that I changed the action trigger branch from master to test....

https://github.com/gymgym1212/apisix-dashboard/runs/6541608647?check_suite_focus=true

I'm very confused about the inconsistent results. Can you help me analyze the reasons?

@Baoyuantop
Copy link
Contributor

Ok, maybe the test code is not stable enough, let me retrigger it

@codecov-commenter
Copy link

Codecov Report

Merging #2453 (7406a38) into master (92f46d9) will decrease coverage by 1.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2453      +/-   ##
==========================================
- Coverage   70.27%   68.83%   -1.44%     
==========================================
  Files         189      131      -58     
  Lines        7492     3456    -4036     
  Branches      845      845              
==========================================
- Hits         5265     2379    -2886     
+ Misses       1922     1077     -845     
+ Partials      305        0     -305     
Flag Coverage Δ
backend-e2e-test ?
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 68.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/server/store.go
api/internal/utils/json_patch.go
api/internal/log/log.go
api/internal/handler/healthz/healthz.go
api/internal/log/zap.go
api/internal/core/store/store.go
api/internal/handler/server_info/server_info.go
api/internal/filter/authentication.go
api/internal/core/migrate/conflict.go
...pi/internal/handler/plugin_config/plugin_config.go
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92f46d9...7406a38. Read the comment docs.

@juzhiyuan juzhiyuan requested a review from guoqqqi May 25, 2022 07:08
@Baoyuantop Baoyuantop requested a review from LiteSun June 1, 2022 02:10
@Baoyuantop
Copy link
Contributor

cc @guoqqqi

@guoqqqi guoqqqi merged commit 8f67daf into apache:master Jun 1, 2022
hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request Jun 16, 2022
* upstream/master:
  test: remove stale E2E cases (apache#2475)
  feat: basic support Apache APISIX 2.14.1 (apache#2464)
  fix: Users can create a Consumer in Dashboard without enabling the plugin (apache#2442)
  fix: change "Route List" to "Routes" (apache#2453)
  fix: advance matching in the route create page causes the page to crash (apache#2440)
  feat: release 2.13 (apache#2458)
  feat: support Turkish Language (apache#2452)

# Conflicts:
#	web/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: i18n improvements
5 participants