-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change "Route List" to "Routes" #2453
Conversation
Signed-off-by: Yeming Gu <yeminggood@gmail.com>
Need to fix a failed front-end E2E, feel free to leave a message if you need help. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as resolved.
This comment was marked as resolved.
Hi @Baoyuantop , I create a https://github.com/gymgym1212/apisix-dashboard/runs/6541608647?check_suite_focus=true I'm very confused about the inconsistent results. Can you help me analyze the reasons? |
Ok, maybe the test code is not stable enough, let me retrigger it |
Codecov Report
@@ Coverage Diff @@
## master #2453 +/- ##
==========================================
- Coverage 70.27% 68.83% -1.44%
==========================================
Files 189 131 -58
Lines 7492 3456 -4036
Branches 845 845
==========================================
- Hits 5265 2379 -2886
+ Misses 1922 1077 -845
+ Partials 305 0 -305
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
cc @guoqqqi |
* upstream/master: test: remove stale E2E cases (apache#2475) feat: basic support Apache APISIX 2.14.1 (apache#2464) fix: Users can create a Consumer in Dashboard without enabling the plugin (apache#2442) fix: change "Route List" to "Routes" (apache#2453) fix: advance matching in the route create page causes the page to crash (apache#2440) feat: release 2.13 (apache#2458) feat: support Turkish Language (apache#2452) # Conflicts: # web/package.json
Signed-off-by: Yeming Gu yeminggood@gmail.com
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Replace
Route List
withRoutes
.But I'm not sure whether it's enough or not.
Related issues
fix/resolve #2387
Checklist: