Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin_config missing on service exist #2657

Merged
merged 4 commits into from
Nov 6, 2022

Conversation

bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented Nov 5, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Ensure that the service and plugin templates in the route can be used at the same time.

Related issues

fix #2648

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@bzp2010 bzp2010 added bug Something isn't working frontend labels Nov 5, 2022
@bzp2010 bzp2010 self-assigned this Nov 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2022

Codecov Report

Merging #2657 (778e987) into master (f64372f) will increase coverage by 2.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2657      +/-   ##
==========================================
+ Coverage   74.33%   76.44%   +2.11%     
==========================================
  Files         201      139      -62     
  Lines        7823     3749    -4074     
  Branches      872      873       +1     
==========================================
- Hits         5815     2866    -2949     
+ Misses       1706      883     -823     
+ Partials      302        0     -302     
Flag Coverage Δ
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 76.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Route/transform.ts 80.52% <100.00%> (+0.10%) ⬆️
api/internal/core/server/server.go
api/internal/core/storage/etcd.go
api/internal/core/server/store.go
api/internal/handler/consumer/consumer.go
api/internal/core/store/store.go
api/internal/handler/global_rule/global_rule.go
api/internal/handler/schema/schema.go
api/main.go
api/internal/handler/label/label.go
... and 53 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bzp2010 bzp2010 marked this pull request as ready for review November 5, 2022 12:59
@bzp2010 bzp2010 merged commit 78ade92 into apache:master Nov 6, 2022
bzp2010 added a commit to bzp2010/apisix-dashboard that referenced this pull request Nov 6, 2022
hongbinhsu added a commit to fitphp/apix-dashboard that referenced this pull request Nov 7, 2022
* upstream/master:
  fix: change default CSP value (apache#2601)
  fix: ant-table unable to request (apache#2641)
  fix: plugin_config missing on service exist (apache#2657)
  feat: add etcd store auto re-initialize (apache#2650)
  feat: add login filter of OpenID-Connect (apache#2608)
  feat:Configure plug-ins to support this feature (apache#2647)
  feat: Adding a Loading state to buttons (apache#2630)
  feat: dashboard support windows (apache#2619)
  Feat: add tip and preset model for plugin editor, improve e2e stability (apache#2581)
  docs: add Slack invitation link badge (apache#2617)

# Conflicts:
#	.github/workflows/backend-cli-test.yml
#	Dockerfile
#	api/test/shell/cli_test.sh
#	web/src/components/Footer/index.tsx
#	web/src/components/RightContent/index.tsx
#	web/src/pages/ServerInfo/List.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
4 participants