Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt APISIX plugin disabled #2717

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

Baoyuantop
Copy link
Contributor

@Baoyuantop Baoyuantop commented Jan 19, 2023

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
Reference apache/apisix#7482. In the new version of APISIX, the plugin disabled move to _meta, and the dashboard needs to be changed synchronously.

Related issues

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #2717 (52c9f59) into master (5ccb55b) will decrease coverage by 6.30%.
The diff coverage is 100.00%.

❗ Current head 52c9f59 differs from pull request most recent head 4f47b63. Consider uploading reports for the commit 4f47b63 to get more accurate results

@@            Coverage Diff             @@
##           master    #2717      +/-   ##
==========================================
- Coverage   74.27%   67.98%   -6.30%     
==========================================
  Files         201       39     -162     
  Lines        7833     1040    -6793     
  Branches      874      268     -606     
==========================================
- Hits         5818      707    -5111     
+ Misses       1712      333    -1379     
+ Partials      303        0     -303     
Flag Coverage Δ
backend-e2e-test-ginkgo ?
backend-unit-test ?
frontend-e2e-test 67.98% <100.00%> (-8.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/PluginDetail.tsx 64.48% <100.00%> (-10.93%) ⬇️
web/src/components/Plugin/PluginPage.tsx 82.00% <100.00%> (-17.00%) ⬇️
web/src/helpers.tsx 19.67% <0.00%> (-57.38%) ⬇️
web/src/components/RightContent/AvatarDropdown.tsx 50.00% <0.00%> (-32.15%) ⬇️
web/src/components/PanelSection/index.tsx 75.00% <0.00%> (-25.00%) ⬇️
...b/src/components/Plugin/UI/referer-restriction.tsx 69.69% <0.00%> (-21.22%) ⬇️
web/src/pages/Consumer/List.tsx 73.17% <0.00%> (-19.52%) ⬇️
web/src/components/ActionBar/ActionBar.tsx 69.23% <0.00%> (-15.39%) ⬇️
web/src/app.tsx 87.87% <0.00%> (-12.13%) ⬇️
... and 170 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Baoyuantop Baoyuantop merged commit 7b8d9c5 into apache:master Jan 20, 2023
@Baoyuantop Baoyuantop deleted the fix-plugin-disabled branch January 20, 2023 01:02
hongbinhsu added a commit to fitphp/apix-dashboard that referenced this pull request Jan 30, 2023
* upstream/master:
  feat: release 3.0.0 (apache#2722)
  Revert "feat: release 2.16.0 (apache#2719)" (apache#2721)
  feat: release 2.16.0 (apache#2719)
  fix: plugin configuration lost in editor (apache#2718)
  fix: adapt APISIX plugin disabled (apache#2717)
  feat: basic support Apache APISIX 3.0.0 (apache#2701)
  feat: change etcd prefix for ssl and proto (apache#2693)
  fix: remove cases external service dependency (apache#2697)
  chore: simplify e2e environment (apache#2694)
  chore: optimize "allow_origins_by_regex tooltip" description (apache#2690)
  feat: release 2.15.0 (apache#2685)
  feat: basic support Apache APISIX 2.15.0 (apache#2680)
  feat: release 2.14.0 (apache#2677)
  fix: bump go version to 1.16 (apache#2678)
  feat: release 2.13.1 (apache#2658)
  feat: support more upstream scheme (apache#2675)
  feat: support purge method (apache#2674)
  feat: add enable flag to oidc function (apache#2672)

# Conflicts:
#	web/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants