feat: add a handler unit test for upstream and remove init #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh,it is automatically merged?what happened... |
|
please revert it |
tokers
changed the title
tokers
reviewed
Nov 21, 2020
| @@ -19,6 +19,10 @@ package consumer | |||
|
|
|||
| import ( | |||
| "encoding/json" | |||
| "fmt" | |||
| "github.com/shiningrush/droplet/data" | |||
There was a problem hiding this comment.
I think it's better to keep the convention about import: the first part is all standard libs, the second part is your local packages in your go module, and the last part is all third party packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is a demo about how to do a real
unit testin handler.I also remove the
initinconfandlog, go is recommended to use explicit initial function instead of implicitinit