-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add skip_mtls_uri_regex
support for ApisixTls
#1915
feat: add skip_mtls_uri_regex
support for ApisixTls
#1915
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1915 +/- ##
==========================================
- Coverage 37.24% 37.23% -0.01%
==========================================
Files 94 94
Lines 7948 7949 +1
==========================================
Hits 2960 2960
- Misses 4595 4596 +1
Partials 393 393 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In test cases, it's best to add an expected failure example and then access it again successfully by adding skip_mtls_uri_regex.
I tried adding all tests on a single route
|
Sorry for the delay. please fix the CI jobs |
@tao12345666333 can you please try rerunning the tasks? I tried running them on my own fork, and they all pass fine. |
…troller into issue-1910-add-add-skip_mtls_uri_regex
let me merge the latest code from master branch. |
Please check the faild jobs. Thanks |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions. |
@aynp The tests are still failing and the failing tests seem relevant to your change. Can you take a look? |
…d-skip_mtls_uri_regex
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
We need to add documentation for this feature. Which version of apisix does this feature depend on? |
@AlinsRan I added the docs where it is also specified that which version supports this feature. |
@Revolyssup The document needs to be updated: The configuration example can be placed here. |
Closes #1910
Type of change:
What this PR does / why we need it:
add
skip_mtls_uri_regex
support for ApisixTlsPre-submission checklist: