Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skip_mtls_uri_regex support for ApisixTls #1915

Merged
merged 14 commits into from
Dec 20, 2023

Conversation

aynp
Copy link
Contributor

@aynp aynp commented Aug 3, 2023

Closes #1910

Type of change:

  • New feature provided

What this PR does / why we need it:

add skip_mtls_uri_regex support for ApisixTls

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a759ae5) 37.24% compared to head (964843e) 37.23%.
Report is 4 commits behind head on master.

❗ Current head 964843e differs from pull request most recent head 3417a75. Consider uploading reports for the commit 3417a75 to get more accurate results

Files Patch % Lines
pkg/providers/apisix/translation/apisix_ssl.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1915      +/-   ##
==========================================
- Coverage   37.24%   37.23%   -0.01%     
==========================================
  Files          94       94              
  Lines        7948     7949       +1     
==========================================
  Hits         2960     2960              
- Misses       4595     4596       +1     
  Partials      393      393              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aynp aynp marked this pull request as ready for review August 4, 2023 04:50
@tao12345666333 tao12345666333 self-requested a review August 8, 2023 07:52
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In test cases, it's best to add an expected failure example and then access it again successfully by adding skip_mtls_uri_regex.

pkg/kube/apisix/apis/config/v2/types.go Outdated Show resolved Hide resolved
@aynp
Copy link
Contributor Author

aynp commented Aug 9, 2023

I tried adding all tests on a single route

  1. Test with correct cert
  2. Test without cert fail
  3. Test without cert but this time with skip_mtls_uri_regex

@tao12345666333
Copy link
Member

Sorry for the delay. please fix the CI jobs

@aynp
Copy link
Contributor Author

aynp commented Aug 29, 2023

@tao12345666333 can you please try rerunning the tasks? I tried running them on my own fork, and they all pass fine.

@tao12345666333
Copy link
Member

let me merge the latest code from master branch.

@tao12345666333
Copy link
Member

Please check the faild jobs. Thanks

@github-actions
Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 31, 2023
@Revolyssup
Copy link
Contributor

@aynp The tests are still failing and the failing tests seem relevant to your change. Can you take a look?

@Revolyssup Revolyssup added this to the 1.8.0 milestone Nov 21, 2023
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
@AlinsRan
Copy link
Contributor

We need to add documentation for this feature.

Which version of apisix does this feature depend on?

@Revolyssup
Copy link
Contributor

@AlinsRan I added the docs where it is also specified that which version supports this feature.

@Revolyssup Revolyssup removed the stale label Dec 19, 2023
@Revolyssup Revolyssup merged commit 10059af into apache:master Dec 20, 2023
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add skip_mtls_uri_regex support for ApisixTls
6 participants