Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: As a user I want to use limit-count plugin with redis-cluster that support tls/ssl. #8413

Closed
harmseru opened this issue Nov 28, 2022 · 6 comments · Fixed by #8558
Closed
Assignees
Labels
good first issue Good for newcomers

Comments

@harmseru
Copy link

harmseru commented Nov 28, 2022

Description

@harmseru
Copy link
Author

@tao12345666333 Here is the issue ticket as requested.

@tao12345666333
Copy link
Member

We can add an option for passing these configurations.
https://github.com/openresty/lua-resty-redis#connect

WDYT? @spacewander

@tao12345666333
Copy link
Member

    local config = {
        ...
        dict_name = "plugin-limit-count-redis-cluster-slot-lock",
        connect_opts = {
         	ssl = true,
                ssl_verify = true,
      ...
      }
   }

It can be like above.

thanks @monkeyDluffy6017

@harmseru
Copy link
Author

Also please enable the ability to disable ssl verification if possible.

@spacewander spacewander added the good first issue Good for newcomers label Nov 28, 2022
@ronething
Copy link
Contributor

hi, i will try this, pls assign to me.

@tao12345666333
Copy link
Member

Thanks @ronething for making it happen.
#8558 has been merged. It will be introduced in the next version @harmseru

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants