Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add id to global_rules schema #9429

Closed
tao12345666333 opened this issue May 8, 2023 · 7 comments
Closed

feat: add id to global_rules schema #9429

tao12345666333 opened this issue May 8, 2023 · 7 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tao12345666333
Copy link
Member

Description

xref: #8439

_M.global_rule = {
type = "object",
properties = {
id = id_schema,
plugins = plugins_schema,
create_time = timestamp_def,
update_time = timestamp_def
},
required = {"plugins"},
}

the id is required.

@tao12345666333 tao12345666333 added good first issue Good for newcomers help wanted Extra attention is needed labels May 8, 2023
@0xtarunkm
Copy link

Hey, I think I can help you out with this can you assign this issue to me?

0xtarunkm added a commit to 0xtarunkm/apisix that referenced this issue May 8, 2023
Added 'id' property to the required section of global_rule schema as per issue apache#9429.
0xtarunkm added a commit to 0xtarunkm/apisix that referenced this issue May 8, 2023
Added 'id' property to the required section of global_rule schema as per issue apache#9429.
@0xtarunkm
Copy link

Hey,

Just wanted to let you all know that I've raised a pull request for issue #9432. It includes the changes we discussed earlier to add the 'id' property to the required section of the global_rule schema.

Please take a look and let me know if you have any feedback or concerns. Your review and feedback would be greatly appreciated.

Thanks!

@tao12345666333
Copy link
Member Author

thanks

#8439 (comment)

please add test case

@howiieyu
Copy link
Contributor

I would like this issue to be assigned to me if possible, thanks.
@spacewander @tao12345666333

@tao12345666333
Copy link
Member Author

@tarunclub has opened a PR for this, but there has been no feedback and no test case added.

If you are willing to work on this, you can open a PR

@howiieyu
Copy link
Contributor

@tao12345666333 I opened a PR for this issue, please check it for #9517 .

@tao12345666333 tao12345666333 assigned howiieyu and unassigned 0xtarunkm Jun 6, 2023
@tao12345666333
Copy link
Member Author

#9517 has been merged, I will close this one, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants