-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add id to global_rules schema #9429
Comments
Hey, I think I can help you out with this can you assign this issue to me? |
Added 'id' property to the required section of global_rule schema as per issue apache#9429.
Added 'id' property to the required section of global_rule schema as per issue apache#9429.
Hey, Just wanted to let you all know that I've raised a pull request for issue #9432. It includes the changes we discussed earlier to add the 'id' property to the required section of the global_rule schema. Please take a look and let me know if you have any feedback or concerns. Your review and feedback would be greatly appreciated. Thanks! |
thanks please add test case |
I would like this issue to be assigned to me if possible, thanks. |
@tarunclub has opened a PR for this, but there has been no feedback and no test case added. If you are willing to work on this, you can open a PR |
@tao12345666333 I opened a PR for this issue, please check it for #9517 . |
#9517 has been merged, I will close this one, thanks. |
Description
xref: #8439
apisix/apisix/schema_def.lua
Lines 831 to 840 in 9ad7402
the
id
is required.The text was updated successfully, but these errors were encountered: