Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: As a user, I want the test of HEC logger with some real cases, so that #9489

Closed
Sn0rt opened this issue May 16, 2023 · 4 comments · Fixed by #9526
Closed

feat: As a user, I want the test of HEC logger with some real cases, so that #9489

Sn0rt opened this issue May 16, 2023 · 4 comments · Fixed by #9526

Comments

@Sn0rt
Copy link
Contributor

Sn0rt commented May 16, 2023

Description

now the test cases of the HEC logger are mock. I want to covert those tests with really.

now the vector supports the HEC source already.

https://vector.dev/docs/reference/configuration/sources/splunk_hec/
https://apisix.apache.org/docs/apisix/plugins/splunk-hec-logging/

@Sn0rt
Copy link
Contributor Author

Sn0rt commented May 17, 2023

/assign @Revolyssup

@Revolyssup
Copy link
Contributor

Can you assign this to me?

@jiangfucheng
Copy link
Member

Now, Partial test cases use splunk server as the real log server and others use mock server, Maybe we replace these server address to splunk server is enough? Do we need use vector as the hec logger server?
https://github.com/apache/apisix/blob/35ea74ee8b7af5c4e3040914d5d535c20d7f7b8b/ci/pod/docker-compose.plugin.yml#LL191C10-L191C10

@Revolyssup
Copy link
Contributor

Now, Partial test cases use splunk server as the real log server and others use mock server, Maybe we replace these server address to splunk server is enough? Do we need use vector as the hec logger server? https://github.com/apache/apisix/blob/35ea74ee8b7af5c4e3040914d5d535c20d7f7b8b/ci/pod/docker-compose.plugin.yml#LL191C10-L191C10

I have made changes locally to replace those partial mock tests. Once your fix around splunk logger gets merged, I will create the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants