feat: Add real tests for splunk logger using vector #9526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: revolyssup <ashishjaitiwari15112000@gmail.com>
Signed-off-by: revolyssup <ashishjaitiwari15112000@gmail.com>
Signed-off-by: revolyssup <ashishjaitiwari15112000@gmail.com>
Signed-off-by: revolyssup <ashishjaitiwari15112000@gmail.com>
|
@Sn0rt please help to review |
Sn0rt
reviewed
May 23, 2023
t/plugin/splunk-hec-logging.t
Outdated
| ["hello world\n", "hello world\n", "hello world\n"] | ||
| --- no_error_log | ||
| [error] | ||
| qr/.*test batched data.*/ |
| @@ -187,18 +187,6 @@ services: | |||
| networks: | |||
| opa_net: | |||
|
|
|||
| # Splunk HEC Logging Service | |||
| splunk: | |||
There was a problem hiding this comment.
Because we don't need a separate splunk server now. Vector does the job
|
please resolve conflicts |
Signed-off-by: revolyssup <ashishjaitiwari15112000@gmail.com>
Signed-off-by: revolyssup <ashishjaitiwari15112000@gmail.com>
| @@ -406,19 +400,23 @@ the mock backend is hit | |||
| if code >= 300 then | |||
| ngx.status = code | |||
| end | |||
| ngx.say(body) | |||
| local code, _, body2 = t("/hello", "GET") | |||
| ngx.status = code | ||
| ngx.say(body) | ||
| return | ||
| end |
| if code >= 300 then | ||
| ngx.status = code | ||
| ngx.say(body) | ||
| return | ||
| end | ||
|
|
||
| local code, _, body2 = t("/hello", "GET") |
| ngx.say(body) | ||
| return | ||
| end | ||
| local code, body = t('/apisix/admin/routes/1', ngx.HTTP_PUT, { |
There was a problem hiding this comment.
Added newline at all suggested place @monkeyDluffy6017
monkeyDluffy6017
added
the
wait for update
Signed-off-by: revolyssup <ashishjaitiwari15112000@gmail.com>
Signed-off-by: revolyssup <ashishjaitiwari15112000@gmail.com>
|
Could you merge the master? The ci always failed because the go packages faile to download. |
@monkeyDluffy6017 I merged master. Please review |
monkeyDluffy6017
approved these changes
Jun 2, 2023
monkeyDluffy6017
added
approved
and removed
wait for update
leslie-tsang
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9489
This PR replaces mock splunk-hec-logger tests with real end to end test using vector as log server.
Checklist