fix: fix and optimize tls in upstream_schema #10269
Conversation
| @@ -402,16 +402,10 @@ local upstream_schema = { | |||
| }, | |||
| }, | |||
| dependencies = { | |||
| client_cert = { | |||
| required = {"client_key"}, | |||
| ["not"] = {required = {"client_cert_id"}} | |||
There was a problem hiding this comment.
Why do you remove the not condition?
There was a problem hiding this comment.
@soulbird please help to check this
There was a problem hiding this comment.
The not condition is not required at both places client_cert and client_cert_id, having the not in clien_cert_id is enough to make both fields mutually exclusive. @monkeyDluffy6017
There was a problem hiding this comment.
As @Revolyssup said, there should only be the following three cases of the three properties(client_cert_id, client_cert, client_key) here:
- None of them exist
- Only client_cert, client_key
- Only client_cert_id
The modified conditions can ensure that "client_cert" and "client_key" must exist at the same time, and three properties will not exist at the same time.
There was a problem hiding this comment.
Could you add some test cases to cover these conditions?
|
hi @wzy0618 , are you still working on this? |
yeah, I just finished my holiday and I will submit it this week. |
Description
Removed two redundant configurations.
Fixed the wrong variables mentioned in the issue.
Fixes #10260
Checklist