Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add name field in plugin_config schema for consistency #10315

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

Revolyssup
Copy link
Contributor

Description

Fixes apache/apisix-ingress-controller#2003
All core resources like service, upstream , route, plugin have name field but plugin_config doesn't and after this PR where additional fields were prohibited, passing name in plugin_config gives an error. Ingress controller currently doesn't differentiate and adds name to plugin_config as well so currently there is this issue between apisix and ingress controller.

So this PR adds the name field to plugin_config to solve the compatibility issue and also for consistency

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility issue: unable to create plugin config with APISIX v3.6
4 participants