Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak caused by timer that never quit #10614

Merged

Conversation

monkeyDluffy6017
Copy link
Contributor

@monkeyDluffy6017 monkeyDluffy6017 commented Dec 7, 2023

Description

The etcd related pr imported a timer that never quits.
According to the official recommendation, the timer will cause memory leak.
image

It will affect all versions between 3.4.0 and 3.7.0, including 3.2.2

Fixes #10392 #10349

steps to reproduce

Frequent configuration changes can cause memory to keep going up.

The memory goes from 0.2% to 1.7% in few hours
094497d0e3ae84914ab41af1f0f6383
image

And the memory keeps stable after fixed
image

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@kingluo kingluo removed their request for review December 8, 2023 01:58
@monkeyDluffy6017 monkeyDluffy6017 merged commit 0bf719e into apache:master Dec 11, 2023
39 checks passed
@Virgil-Zhou
Copy link

May I ask when the updated version will be fixed? I don't want to roll back the version.

@monkeyDluffy6017
Copy link
Contributor Author

@Virgil-Zhou No plan right now, maybe you could pick it yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

help request: memory growing up
4 participants