fix: cache original_nodes with nodes #10722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZhangShangyu could you please review? |
sheharyaar
changed the title
|
@monkeyDluffy6017 , I have made some changes to the PR, please review this. |
sheharyaar
changed the title
sheharyaar
changed the title
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
shreemaan-abhishek
approved these changes
Jan 3, 2024
monkeyDluffy6017
approved these changes
Jan 3, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upstream original_nodes is not updated when fill_node_info structure after cloning the nodes table. This PR stores the cloned nodes in the original nodes before fill_node_info
Fixes # (issue)
#9805
Checklist