Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elasticsearch-logger): add compatibility headers #10828

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

lakshya8066
Copy link
Contributor

@lakshya8066 lakshya8066 commented Jan 16, 2024

Description

  1. Add compatibility headers to ensure smooth transition from version 7.x to 8.x
  2. update the elasticsearch in test env

Fixes #8647

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@pottekkat
Copy link
Contributor

Could you check the failing test cases? It is because of this change.

@lakshya8066 lakshya8066 changed the title fix: elasticsearch version fix: add compatibility headers Jan 17, 2024
@shreemaan-abhishek shreemaan-abhishek marked this pull request as ready for review January 18, 2024 03:34
@monkeyDluffy6017 monkeyDluffy6017 changed the title fix: add compatibility headers fix(elasticsearch-logger): add compatibility headers Jan 18, 2024
@monkeyDluffy6017
Copy link
Contributor

This PR changes the version of the elastic search used for testing the elasticsearch-logger plugin to version 8.11.3

I didn't see this?

@lakshya8066
Copy link
Contributor Author

oh my bad, initially this PR was supposed to change the version as well but I am getting errors on upgrading the version. I don't know how to solve the errors.
So for now, I am just adding the headers. I will change the version as soon as I detect the bug

@monkeyDluffy6017 monkeyDluffy6017 marked this pull request as draft January 19, 2024 01:59
@monkeyDluffy6017 monkeyDluffy6017 marked this pull request as ready for review January 19, 2024 01:59
@monkeyDluffy6017
Copy link
Contributor

The pr seems not ready if you don't upgrade the elasticsearch

@shreemaan-abhishek
Copy link
Contributor

@gaoxingliang please review if you can.

Copy link
Contributor

@Revolyssup Revolyssup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monkeyDluffy6017 monkeyDluffy6017 merged commit 77585e2 into apache:master Feb 1, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants