-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(elasticsearch-logger): add compatibility headers #10828
Conversation
Could you check the failing test cases? It is because of this change. |
I didn't see this? |
oh my bad, initially this PR was supposed to change the version as well but I am getting errors on upgrading the version. I don't know how to solve the errors. |
The pr seems not ready if you don't upgrade the elasticsearch |
@gaoxingliang please review if you can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
7.x
to8.x
Fixes #8647
Checklist