-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: jwe-decrypt secret length must be 32 chars #10883
docs: jwe-decrypt secret length must be 32 chars #10883
Conversation
Signed-off-by: Vacant2333 <vacang2333@gmail.com>
@kayx23 @shreemaan-abhishek can u help me take a look~ |
| Name | Type | Required | Default | Valid values | Description | | ||
|---------------|---------|-------------------------------------------------------|---------|-----------------------------|------------------------------------------------------------------------------------------------------------------------------------------| | ||
| key | string | True | | | Unique key for a Consumer. | | ||
| secret | string | True | | | The decryption key. The key could be saved in a secret manager using the [Secret](../terminology/secret.md) resource. (Must be 32 chars) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| secret | string | True | | | The decryption key. The key could be saved in a secret manager using the [Secret](../terminology/secret.md) resource. (Must be 32 chars) | | |
| secret | string | True | | | The decryption key. Must be 32 characters. The key could be saved in a secret manager using the [Secret](../terminology/secret.md) resource. | |
| 名称 | 类型 | 必选项 | 默认值 | 有效值 | 描述 | | ||
|---------------|---------|-------|-------|-----|-------------------------------------------------------------------| | ||
| key | string | True | | | Consumer 的唯一 key | | ||
| secret | string | True | | | 解密密钥。秘钥可以使用 [Secret](../terminology/secret.md) 资源保存在密钥管理服务中(32 位) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| secret | string | True | | | 解密密钥。秘钥可以使用 [Secret](../terminology/secret.md) 资源保存在密钥管理服务中(32 位) | | |
| secret | string | True | | | 解密密钥,必须为 32 位。秘钥可以使用 [Secret](../terminology/secret.md) 资源保存在密钥管理服务中 | |
i need time to confirm is the solution right, close the pr now |
Signed-off-by: Vacant2333 <vacang2333@gmail.com>
i have remote the |
You mean remove? And where is it removed? |
f2890ef#diff-6529ea6d6dfb2a162df8b4ef89a760c9acba198e139fba0faa58aed1e18dac08L50 here, In the first commit, I wanted to limit its length to the exact 32 bytes, but ci failed, because we have the requirement of base64, so I shouldn't have limited the length in scheme. I removed it in the second commit. |
@Vacant2333 you must also update the schema, shouldn't you? And is there any spec/rfc that supports your claim? |
no, we cant limit the schemea, if use set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Vacant2333 In that case, why is this PR still saying the secret must be 32 chars, instead of explaining more of what you explain above? |
yes, u r right! i will raise a pr to mention these infomations, and it will check the secret length when APISIX running |
Description
Fixes # (issue 10825)
Checklist