Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(grpc-transcode): adjust the position of enums in pb_option_def #11448

Merged
merged 2 commits into from
Aug 5, 2024
Merged

chore(grpc-transcode): adjust the position of enums in pb_option_def #11448

merged 2 commits into from
Aug 5, 2024

Conversation

zhoujiexiong
Copy link
Contributor

No description provided.

moonming
moonming reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@moonming moonming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch.
Do we need to add test cases?

@zhoujiexiong
Copy link
Contributor Author

good catch.
Do we need to add test cases?

@moonming Sure and already added.

@zhoujiexiong
Copy link
Contributor Author

@moonming @membphis @shreemaan-abhishek
Help review? :D

@nic-chen nic-chen merged commit e746746 into apache:master Aug 5, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

@nic-chen nic-chen nic-chen approved these changes

@moonming moonming moonming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhoujiexiong @moonming @nic-chen @shreemaan-abhishek