bugfix: should not save the runtime data of plugin into etcd.
#1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
Jul 27, 2020
apisix/core/json.lua
Outdated
| @@ -26,6 +27,7 @@ local cached_tab = {} | |||
| local _M = { | |||
| version = 0.1, | |||
| decode = require("cjson.safe").decode, | |||
| sort_encode = require("apisix.core.json_sort").encode, | |||
There was a problem hiding this comment.
Better to use name encode_with_keys_sorted.
moonming
reviewed
Jul 27, 2020
apisix/core/json.lua
Outdated
| @@ -26,6 +27,7 @@ local cached_tab = {} | |||
| local _M = { | |||
| version = 0.1, | |||
| decode = require("cjson.safe").decode, | |||
| sort_encode = require("apisix.core.json_sort").encode, | |||
There was a problem hiding this comment.
Is this function only for test cases?
apisix/core/json_sort.lua
Outdated
| -- See the License for the specific language governing permissions and | ||
| -- limitations under the License. | ||
| -- | ||
|
|
There was a problem hiding this comment.
we should not put this file to core if it only for test cases.
spacewander
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
as title.
fixed #1836 .
Pre-submission checklist: