bugfix: deleted the object by Admin API, and the cache was not properly cleaned up during etcd data synchronization. #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nic-chen
reviewed
Sep 4, 2020
moonming
reviewed
Sep 5, 2020
nic-chen
approved these changes
Sep 16, 2020
stale boolean data in table `self.values` with a safer way.
moonming
approved these changes
Sep 17, 2020
membphis
changed the title
delete action, and removing stale boolean data in table self.values with a safer way
nic-chen
pushed a commit
to api7/apisix
that referenced
this pull request
Dec 14, 2020
…ly cleaned up during etcd data synchronization. apache#2168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If the administrator user creates and deletes the same route multiple times, the new route will not be correctly synchronized to the APISIX gateway node, resulting in some request route matching failures and a 404 response.
bugfix: clear all cached data when get delete action, and removing stale boolean data in table self.values with a safer way
Pre-submission checklist: