Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support specifying https in upstream to talk with https backend #3430

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

spacewander
Copy link
Member

Fix #3336
Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Fix apache#3336
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander changed the title feat: support specifying https in upstream feat: support specifying https in upstream to talk with https backend Jan 27, 2021
@spacewander spacewander marked this pull request as ready for review January 27, 2021 03:18
@Firstsawyou
Copy link
Contributor

LGTM.

@tokers
Copy link
Contributor

tokers commented Jan 27, 2021

@spacewander Have you tested it with the cooperation of proxy-rewrite plugin (change the scheme), need to make sure they can work together.

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander
Copy link
Member Author

@tokers
More tests added.

@spacewander spacewander merged commit 3a09f8a into apache:master Jan 27, 2021
@spacewander spacewander deleted the https branch January 27, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support to specify the scheme(http/https) in upstream
4 participants