fix(traffic-split): binding upstream via upstream_id is invalid #3842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix #3740
Related issues: #3787
Because the current traffic-split plug-in supports
upstream_id
to refer to the upstream by rewriting the value ofctx.matched_route.value.upstream_id
. However, when the upstream_id is used by the route and the plugin at the same time, the rewriting ofctx
will cause theupstream_id
on the original cached route to be lost.Therefore, this PR creates a temporary variable of
ctx.upstream_id
to cache the upstream_id configured in the plug-in, avoiding the modification ofctx.matched_route.value.upstream_id
.Pre-submission checklist: