fix(healthcheck): only one_loop is needed in the passive health check report #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
changed the title
spacewander
reviewed
Apr 23, 2021
apisix/init.lua
Outdated
| end | ||
| if resp_status == status then | ||
| checker:report_http_status(api_ctx.balancer_ip, | ||
| port or api_ctx.balancer_port, |
There was a problem hiding this comment.
Please keep the original indentation with space
There was a problem hiding this comment.
@Ben0625
You can create another commit in this branch to fix it, and push it again.
spacewander
approved these changes
Apr 26, 2021
Yiyiyimu
approved these changes
Apr 26, 2021
tokers
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4103
Pre-submission checklist: